Add xattr and chunked_format documentation#28
Conversation
|
Note: chunked_format.md now describing some 48bit layout-specific fields, wondering whether move them to a separate 48bit.md? |
There was a problem hiding this comment.
Pull request overview
Adds new on-disk format documentation for EROFS optional features (xattrs and chunk-based files) and links them from the on-disk docs index.
Changes:
- Added a new
xattrs.mdpage describing xattr-related superblock/inode fields and on-disk layouts. - Added a new
chunked_format.mdpage describing chunk-based inode layouts and multi-device addressing. - Updated
ondisk/index.mdto link and include the new pages in the toctree.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/ondisk/xattrs.md | New documentation page for xattr features, layouts, and feature flags |
| src/ondisk/index.md | Adds links + toctree entries for the new optional-feature docs |
| src/ondisk/chunked_format.md | New documentation page for chunk-based format and device table resolution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e36f0b6 to
67575f5
Compare
|
@hsiangkao Regarding the 48-bit layout fields in chunked_format.md — since you Happy to help refine the structure if needed. |
Hi Shailesh, Thanks for your interest. We already have a draft and will submit a pull request soon. If you're interested in helping us polish and improve the current (and future) documentation, we would greatly appreciate it. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/ondisk/xattrs.md
Outdated
| - A bit value of **0** means a matching xattr **may exist** and a full scan is | ||
| required. | ||
|
|
||
| When `xattr_filter_reserved` in the superblock is non-zero, the bloom filter is |
There was a problem hiding this comment.
Terminology is inconsistent with earlier uses of “Bloom filter” in this document. For clarity and consistency (and easier searching), consider capitalizing it here as well (“Bloom filter”).
| When `xattr_filter_reserved` in the superblock is non-zero, the bloom filter is | |
| When `xattr_filter_reserved` in the superblock is non-zero, the Bloom filter is |
|
@SToPire @hsiangkao Thanks for the response! I'd be happy to help improve and polish the documentation. While going through the current changes, I noticed a few small things that could be clarified or made more consistent:
I can prepare a small follow-up PR for these improvements if that sounds good. Thanks again! |
|
@SToPire @hsiangkao I've opened a follow-up PR (#29) with the small clarity improvements I mentioned — reserved value note, Bloom filter capitalization, and the chunk size formula wording. Happy to adjust anything based on your feedback! |
[ Assisted with revisions and language polishing using GPT-5.4. ] Assisted-by: Shailesh kumar <shailesh91199477@gmail.com> Signed-off-by: Yifan Zhao <yifan.yfzhao@foxmail.com>
[ Assisted with revisions and language polishing using GPT-5.4. ] Signed-off-by: Yifan Zhao <yifan.yfzhao@foxmail.com>
Signed-off-by: Yifan Zhao <yifan.yfzhao@foxmail.com>
67575f5 to
269bc08
Compare
No description provided.