Skip to content

Replace cJSON by nlohmann::ordered_json#3896

Merged
eranif merged 1 commit intoeranif:masterfrom
Jarod42:json_migration
Mar 28, 2026
Merged

Replace cJSON by nlohmann::ordered_json#3896
eranif merged 1 commit intoeranif:masterfrom
Jarod42:json_migration

Conversation

@Jarod42
Copy link
Copy Markdown
Collaborator

@Jarod42 Jarod42 commented Mar 23, 2026

Using ordered version to better mimic old behavior which keeps insertion order

@Jarod42 Jarod42 marked this pull request as draft March 23, 2026 10:07
Using ordered version to better mimic old behavior which keeps insertion order
@Jarod42 Jarod42 marked this pull request as ready for review March 28, 2026 13:12
@Jarod42
Copy link
Copy Markdown
Collaborator Author

Jarod42 commented Mar 28, 2026

@eranif All is ok on my side.
I missed parsing-handling in the first version (we try to parse (xml) workspace as json ?!).
You might do further testing if you want :-)

@Jarod42 Jarod42 requested a review from eranif March 28, 2026 13:55
@eranif
Copy link
Copy Markdown
Owner

eranif commented Mar 28, 2026

I am just going to merge this and test it, hopefully nothing will break 🤣

@eranif eranif merged commit 9b5cad8 into eranif:master Mar 28, 2026
8 checks passed
@eranif
Copy link
Copy Markdown
Owner

eranif commented Mar 28, 2026

@Jarod42 so far so good...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants