Skip to content

Make head and tail calls more memory efficient#1

Open
cgray wants to merge 1 commit intoequip:masterfrom
cgray:performance/improve-memory-usage-in-head-and-tail
Open

Make head and tail calls more memory efficient#1
cgray wants to merge 1 commit intoequip:masterfrom
cgray:performance/improve-memory-usage-in-head-and-tail

Conversation

@cgray
Copy link
Copy Markdown

@cgray cgray commented Mar 17, 2016

Used array_slice instead of array_pop/array_shift to keep a copy of the source array from being created

Used array_slice as opposed to using array_pop/array_shift to keep a copy of the source array from being created
shadowhand added a commit that referenced this pull request Mar 21, 2016
In order to verify changes to functions that might affect performance.

Refs #1
@shadowhand shadowhand mentioned this pull request Mar 21, 2016
shadowhand added a commit that referenced this pull request Mar 21, 2016
In order to verify changes to functions that might affect performance.

Also runs benchmarks during builds for easy comparison.

Refs #1
@shadowhand
Copy link
Copy Markdown
Contributor

@cgray can you rebase this so that we can compare before/after performance (see #2)?

@ameech
Copy link
Copy Markdown
Contributor

ameech commented Apr 1, 2016

@cgray any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants