Open
Conversation
Hannahbird
requested review from
dcharles525 and
johnlcos
and removed request for
dcharles525
Hannahbird
force-pushed
the
feat/EPINIO-479__trailhand_table
branch
from
4bafade to
6d65ea6
Compare
…ew tag and action components as well
Replace custom DataTable.vue and Rancher SortableTable across all list, detail, and page views with the trailhand data-table web component for consistency with the design system. Extract all shared cell renderers into utils/table-formatters.ts, eliminating duplicated DOM construction logic across components. Helpers cover state tags, router links, commit SHA/author cells, app routes, and build progress cells. Apply dark mode hover CSS variables to every data-table instance. Configure vue.config.js isCustomElement to suppress Vue compiler warnings for web component tag names.
Hannahbird
force-pushed
the
feat/EPINIO-479__trailhand_table
branch
from
6d65ea6 to
5b9de2e
Compare
johnlcos
requested changes
Mar 6, 2026
| :row-actions="false" | ||
| default-sort-by="epinio-name" | ||
| :search="false" | ||
| <data-table |
Collaborator
There was a problem hiding this comment.
Should have called this out in trailhand, but I think we should add "trailhand-" to the component name for consistency.
| label: t('tableHeaders.description'), | ||
| width: '450px', | ||
| sortable: false, | ||
| formatter: (_v: any, row: any) => { |
Collaborator
There was a problem hiding this comment.
Looks like there is some formatting issues here.
johnlcos
requested changes
Mar 6, 2026
|
|
||
| <DataTable | ||
| :rows="apps" | ||
| <data-table |
Collaborator
There was a problem hiding this comment.
This applies to all tables, but the bg color state for the top row behaves a bit strangely after sorting. It is especially noticeable on dark mode
johnlcos
requested changes
Mar 6, 2026
| </template> | ||
| </Masthead> | ||
| <DataTable | ||
| <data-table |
Collaborator
There was a problem hiding this comment.
We need an action to delete the namespace
(pic of old table)
johnlcos
requested changes
Mar 6, 2026
| </template> | ||
| </Masthead> | ||
| <DataTable | ||
| <data-table |
Collaborator
There was a problem hiding this comment.
Looks like services is also missing its actions
| </template> | ||
| </Masthead> | ||
| <DataTable | ||
| <data-table |
|
|
||
| <template> | ||
| <DataTable | ||
| <data-table |
Collaborator
There was a problem hiding this comment.
Not sure if there is a case where there are supposed to be actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
Fixes #
Adopt the trailhand data-table web component across all Epinio UI list, detail, and page views, replacing the legacy custom DataTable.vue and Rancher SortableTable components.
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Light mode - Applications Page