test: add unit tests for str SanitizeLabelName#8460
Open
archy-rock3t-cloud wants to merge 1 commit intoenvoyproxy:mainfrom
Open
test: add unit tests for str SanitizeLabelName#8460archy-rock3t-cloud wants to merge 1 commit intoenvoyproxy:mainfrom
archy-rock3t-cloud wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Artem Muterko <artem@sopho.tech>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8460 +/- ##
==========================================
- Coverage 74.18% 74.16% -0.03%
==========================================
Files 242 242
Lines 37310 37579 +269
==========================================
+ Hits 27678 27870 +192
- Misses 7698 7769 +71
- Partials 1934 1940 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
test: add unit tests for label name sanitization
What this PR does / why we need it:
Adds table-driven unit tests for
SanitizeLabelNameininternal/utils/str. Covers empty input, valid labels, and replacement of hyphens, dots, mixed special characters, and spaces.Which issue(s) this PR fixes:
N/A — test coverage improvement
Release Notes: No