feat: support GatewayStaticAddresses conformance test#8395
Open
cnvergence wants to merge 1 commit intoenvoyproxy:mainfrom
Open
feat: support GatewayStaticAddresses conformance test#8395cnvergence wants to merge 1 commit intoenvoyproxy:mainfrom
cnvergence wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (47.87%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8395 +/- ##
==========================================
- Coverage 74.16% 74.07% -0.09%
==========================================
Files 242 242
Lines 37603 37665 +62
==========================================
+ Hits 27888 27901 +13
- Misses 7774 7819 +45
- Partials 1941 1945 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cnvergence
force-pushed
the
enable-static-addr-test
branch
from
1566f7d to
f77c976
Compare
cnvergence
force-pushed
the
enable-static-addr-test
branch
2 times, most recently
from
69fdf60 to
3f203b7
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
zirain
force-pushed
the
enable-static-addr-test
branch
from
3f203b7 to
3661cf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Implemented support for static gateway addresses to pass the GatewayStaticAddresses conformance test.
Validate address types in
GetRelevantGateways, rejecting unsupported types with UnsupportedAddress, added reportingAddressNotUsablewhenspec.Addressescan't be satisfied by the LB controller.Which issue(s) this PR fixes:
Fixes #2001
Release Notes: Yes/No