docs: remove references to non-existent bazel/setup_clang.sh (#43808)#43965
Open
stekole wants to merge 1 commit intoenvoyproxy:mainfrom
Open
docs: remove references to non-existent bazel/setup_clang.sh (#43808)#43965stekole wants to merge 1 commit intoenvoyproxy:mainfrom
stekole wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
…oxy#43808) Commit Message: docs: remove references to non-existent bazel/setup_clang.sh Additional Description: The clang toolchain is now hermetic and automatically downloaded by Bazel, so bazel/setup_clang.sh no longer exists. Updated bazel/README.md to reflect the current setup process, fixed a stale comment in .bazelrc, and removed outdated shell_commands in .bazelci/presubmit.yml. Risk Level: Low Testing: N/A (docs/config only) Docs Changes: Updated bazel/README.md Release Notes: N/A Fixes envoyproxy#43808 Signed-off-by: stekole <stefan@sandnetworks.com>
stekole
requested a deployment
to
external-contributors
GitHub Actions
Waiting
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-cncf-pr/43965/docs/index.html The docs are (re-)rendered each time the CI |
|
Hi @stekole, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: docs: remove references to non-existent bazel/setup_clang.sh
Additional Description: The clang toolchain is now hermetic and automatically downloaded by Bazel, so bazel/setup_clang.sh no longer exists. Updated
bazel/README.mdto reflect the current setup process, fixed a stale comment in.bazelrc, and removed outdated shell_commands in.bazelci/presubmit.yml.Risk Level: Low (docs only)
Testing:N/A
Docs Changes: Updated bazel/README.md
Release Notes: N/A
Platform Specific Features: N/A
Fixes: 43808
Signed-off-by: stekole stefan@sandnetworks.com
CC: @phlax