Skip to content

feat(spectrum calc): option to include different ions#158

Draft
engeir wants to merge 3 commits intomainfrom
multiple-ions
Draft

feat(spectrum calc): option to include different ions#158
engeir wants to merge 3 commits intomainfrom
multiple-ions

Conversation

@engeir
Copy link
Copy Markdown
Owner

@engeir engeir commented Dec 18, 2022

An attempt at opening for including different ion species.

An attempt at opening for including different ion species.
@engeir engeir added enhancement New feature or request python Pull requests that update Python code labels Dec 18, 2022
Eirik Rolland Enger added 2 commits December 18, 2022 15:22
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 19, 2022

Codecov Report

Merging #158 (63944a7) into main (bd57aaa) will decrease coverage by 0.96%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   68.75%   67.78%   -0.97%     
==========================================
  Files           7        7              
  Lines         352      357       +5     
==========================================
  Hits          242      242              
- Misses        110      115       +5     
Impacted Files Coverage Δ
src/inscar/spectrum_calculation.py 44.70% <27.27%> (-2.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@engeir engeir marked this pull request as draft February 27, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant