feat: add command step type execution to workflows#526
Merged
Conversation
Co-Authored-By: Rover <noreply@endor.dev>
Collaborator
Author
|
To be merged when this gets released: endorhq/docs#39 |
Angelmmiguel
approved these changes
Feb 24, 2026
Contributor
Angelmmiguel
left a comment
There was a problem hiding this comment.
LGTM! Nice job and refactor 😄
| - **Node version**: Requires Node.js 20+ and pnpm 10+ (see root package.json engines) | ||
| - **Monorepo**: Uses pnpm workspaces for package management | ||
|
|
||
| ### Process Execution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
commandstep type in workflow execution, allowing workflows to run shell commands directly alongside AI agent steps. This enables mixed workflows where deterministic tasks (builds, linting, tests) execute as subprocesses while AI-driven tasks are dispatched to agent runners.The step execution logic has been refactored from the
runcommand intoWorkflowManager.run(), centralizing the orchestration of both step types. Command steps capturestdout/stderras step outputs and supportallow_failureto continue execution on non-zero exit codes.Changes
WorkflowStepSchemaas a discriminated union ofagentandcommandstep types, replacing the previous agent-only schemaisCommandSteptype guard and exported it fromrover-schemasallow_failurefield toWorkflowCommandStepSchemafor fault-tolerant command stepsWorkflowManager.run()method that orchestrates step execution: command steps run vialaunchSync, agent steps are delegated to a caller-providedAgentStepExecutorcallbackStepResult,AgentStepExecutor,OnStepComplete, andWorkflowRunResulttypes intorover-coreas shared interfacesRunnerStepResultandACPRunnerStepResultto extend the sharedStepResultinterfaceruncommand by removing duplicated step-loop logic for ACP and standard modes, replacing it with a singleagentStepExecutorcallback passed toWorkflowManager.run()WorkflowManager.run()covering command execution, agent delegation,continueOnError,allow_failure, output accumulation, and step completion callbacksallow_failure, and mixed step typescommand step executionfeature documentation toE2E_TESTS.mdAGENTS.mdNotes
Context injection (
handleContextInjection) now only applies to agent steps via theisAgentStepguard, since command steps do not have prompts.Closes: #524