Skip to content

NXT-574: Enhanced resolution related logic #3392

Merged
vJIYEv merged 10 commits intodevelopfrom
feature/NXT-574
Mar 6, 2026
Merged

NXT-574: Enhanced resolution related logic #3392
vJIYEv merged 10 commits intodevelopfrom
feature/NXT-574

Conversation

@ion-andrusciac-lgp
Copy link
Contributor

@ion-andrusciac-lgp ion-andrusciac-lgp commented Feb 18, 2026

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Enhanced resolution related logic

Resolution

  • Removed matchSmallerScreenType
  • Renamed intermediateScreenHandling to fontSizeHandling and changed its default value to scale
  • Modified getScreenType() function. Now, this function returns the exact match of the screen type from largest to smallest type or the closest screen type to the current resolution.
  • Modified selectSrc() function. The function uses the same logic mentioned above, and now it returns the closest image type to the current resolution. Before this change, if the image src did not match the current screen type, the default value was returned, which was src.fhd || src.uhd || src.hd.

Additional Considerations

Links

NXT-574

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.62%. Comparing base (85353b5) to head (b67ba38).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3392      +/-   ##
===========================================
+ Coverage    83.18%   83.62%   +0.44%     
===========================================
  Files          154      154              
  Lines         7332     7359      +27     
  Branches      1927     1929       +2     
===========================================
+ Hits          6099     6154      +55     
+ Misses         969      948      -21     
+ Partials       264      257       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bu it is an API breaking change, so we should double check before merging

Copy link
Contributor

@alexandrumorariu alexandrumorariu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vJIYEv vJIYEv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vJIYEv vJIYEv merged commit 32e7619 into develop Mar 6, 2026
8 checks passed
@vJIYEv vJIYEv deleted the feature/NXT-574 branch March 6, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants