Fix Scale::FitScreen on X11 choosing too large scale#397
Merged
emoon merged 1 commit intoemoon:masterfrom Mar 3, 2026
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
Scale::FitScreen, the scale was chosen incorrectly in some cases (e.g. with the requested height of 320 and the screen height of 2160 pixels) so that the window was larger than the screen. This patch fixes the calculation.The problem seems to be identical to #52 but that one was fixed 8 years ago. The sample from it can be used to reproduce but the height needs to be adapted to the screen height (something like 1/6 of screen height should work).
This patch doesn’t address the fact the taskbar, window frame, and such are ignored in the calculation.