Skip to content

mac: improve numPad codes in KEY_MAPPINGS#393

Merged
emoon merged 2 commits intoemoon:masterfrom
gorsat:mac-num-pad
Dec 6, 2025
Merged

mac: improve numPad codes in KEY_MAPPINGS#393
emoon merged 2 commits intoemoon:masterfrom
gorsat:mac-num-pad

Conversation

@gorsat
Copy link
Copy Markdown
Contributor

@gorsat gorsat commented Dec 5, 2025

Added several num pad keys that were missing in KEY_MAPPINGS for mac.

@gorsat
Copy link
Copy Markdown
Contributor Author

gorsat commented Dec 5, 2025

oops. I had to run cargo fmt with an empty config file in order to catch these format problems.

@gorsat
Copy link
Copy Markdown
Contributor Author

gorsat commented Dec 5, 2025

NOTE: I should have mentioned in the original PR that this changes the mapping of keyCode 0x4c from Key::Enter to Key::NumPadEnter. This is consistent with the Windows implementation but if someone is relying on the existing mapping then this could be a breaking change for them. The other changes simply replace Key::Unknown with Key::NumPad... which seems unlikely to break anything but possibly could.

@emoon emoon merged commit e0cfce2 into emoon:master Dec 6, 2025
4 checks passed
@emoon
Copy link
Copy Markdown
Owner

emoon commented Dec 6, 2025

Thanks! Yes, I think it's unlikely this would be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants