Skip to content

Update assignment_1.ipynb#1

Open
emilyzohar wants to merge 2 commits intomainfrom
assignment-1
Open

Update assignment_1.ipynb#1
emilyzohar wants to merge 2 commits intomainfrom
assignment-1

Conversation

@emilyzohar
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Completed assignment 1

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • [ X] I can confirm that my changes are working as intended

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! One note for improvement would be to simplify your conditional logic in part b. Since is_case_sensitive is already a Boolean, you do not need to explicitly check == True or == False. You could simplify the condition by using if not is_case_sensitive: instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants