Fix for Darwin when pthread_threadid_np is unavailable#276
Open
barracuda156 wants to merge 1 commit intoemilk:masterfrom
Open
Fix for Darwin when pthread_threadid_np is unavailable#276barracuda156 wants to merge 1 commit intoemilk:masterfrom
barracuda156 wants to merge 1 commit intoemilk:masterfrom
Conversation
seanm
reviewed
Jun 20, 2025
Comment on lines
+1100
to
+1104
| #if MAC_OS_X_VERSION_MAX_ALLOWED < 1060 || defined(__POWERPC__) | ||
| thread_id = pthread_mach_thread_np(pthread_self()); | ||
| #else | ||
| pthread_threadid_np(pthread_self(), &thread_id); | ||
| #endif |
There was a problem hiding this comment.
This isn't quite the right check. MAC_OS_X_VERSION_MAX_ALLOWED checks the SDK being built against. Better to check MAC_OS_X_VERSION_MIN_REQUIRED which is the deployment version. You could build against the 10.5 SDK but deploy back to 10.4 for example.
I suggest:
#if MAC_OS_X_VERSION_MIN_REQUIRED >= 1060
new_fn();
#else
old_fun();
#endif
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pthread_threadid_npdoes not exist before 10.6 and is not available in 10.6 for powerpc. Provide a fallback for it.