Update all cmake_minimum_required to 3.12; support CMake 4.0#257
Open
musicinmybrain wants to merge 1 commit intoemilk:masterfrom
Open
Update all cmake_minimum_required to 3.12; support CMake 4.0#257musicinmybrain wants to merge 1 commit intoemilk:masterfrom
musicinmybrain wants to merge 1 commit intoemilk:masterfrom
Conversation
CMake 4.0 drops support for CMake <3.5, so minimum versions need to be adjusted for forward compatibility. As long as we are touching minimum versions, let’s harmonize them all at 3.12, which can be considered the oldest “modern” CMake release, and which is available in all known supported Linux distributions today.
Conan-Kudo
approved these changes
Mar 5, 2025
|
Seems preferable to bump only to 3.5, the minimum needed for CMake 4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 4.0 drops support for CMake <3.5, so minimum versions need to be adjusted for forward compatibility. As long as we are touching minimum versions, let’s harmonize them all at 3.12, which can be considered the oldest “modern” CMake release, and which is available in all known supported Linux distributions today.
I tested this (as best I could) with CMake 4.0.0rc2.