Replace _fsopen on Windows to allow the opened file to be used by logrotate (supporting move and delete operations)#251
Open
sunbuny wants to merge 2 commits intoemilk:masterfrom
Open
Replace _fsopen on Windows to allow the opened file to be used by logrotate (supporting move and delete operations)#251sunbuny wants to merge 2 commits intoemilk:masterfrom
sunbuny wants to merge 2 commits intoemilk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using loguru on Windows with
#define LOGURU_WITH_FILEABS 1,logrotatecannot be used to manage the growing file size. This is because files opened with _fsopen cannot be used by logrotate while the process is still running. I made some modifications to solve this issue and conducted some tests.