Hints: Support 'sound-file' and 'sound-name' hints in makoctl list#470
Hints: Support 'sound-file' and 'sound-name' hints in makoctl list#470earboxer wants to merge 3 commits intoemersion:masterfrom
Conversation
|
Should probably add a "suppress-sound" BOOLEAN criteria... not sure how widely used any of these are. Dino at least sends To improve the user-experience, maybe there should be an 'on-dismiss' binding, because I want to kill the sound AND close the notification. (And probably the actions should work with this... not sure if that would be possible to script. maybe I'm asking too much of mako at this point.) |
|
If we implement "truthy/falsey" string comparisons first as in #471, then it will be easier to specify the config: |
|
What if we (optionally) depend on @emersion if you're okay with adding an optional dependency (there's precedent with |
|
I'm not convinced mako should have built-in support for sound files. |
Reference: https://specifications.freedesktop.org/notification-spec/latest/ar01s08.html
Added sound-file and sound-name to the data so they'll appear in makoctl list. Also added a criteria for sound-name.
You can use this config to play the sounds:
Closes #424
Testing notes: