WIP: allow totalDifficulty to be the same#145
Draft
ligi wants to merge 1 commit intoemeraldpay:masterfrom
Draft
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a PR to discuss and progress to fix #132
as a WIP/Draft currently as I am not sure about is the impact on non ethereum chains - for our Ethereum case it seems to work fine cc @skylenet
PS: maybe also one refactor would be nice - renaming difficulty to totalDifficulty - this really send me on the wrong track that the difficulty I saw not moving anymore and not being 0 was actually the totalDifficutly just named difficulty.