Pin onnxruntime version due to lacking python 3.10 support#772
Open
Pin onnxruntime version due to lacking python 3.10 support#772
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins onnxruntime to avoid lock regeneration/install issues caused by upstream Python 3.10 support being dropped (and incorrectly reflected in package metadata for several releases), which affects uv when resolving dependencies for the onnx extra.
Changes:
- Add an upper bound to
onnxruntimein theonnxoptional dependency group. - Mirror the same constraint in
uv.lock’s project metadata requirements.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pyproject.toml |
Caps onnxruntime for the onnx extra to avoid incompatible releases during resolution. |
uv.lock |
Updates the locked project metadata requirement for onnxruntime to match the new constraint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AVHopp
force-pushed
the
repo/pin_onnxruntime
branch
from
a5c3cbb to
5689926
Compare
AVHopp
force-pushed
the
repo/pin_onnxruntime
branch
from
5689926 to
a514e33
Compare
Scienfitz
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release
1.24.1ofonnxruntimedropped support for Python 3.10, see https://github.com/microsoft/onnxruntime/releases/tag/v1.24.1. Unfortunately, they did not properly update their metadata, which causes issues when trying to install the package asuvthinks that python 3.10 is still supported for several versions that actually do not support this anymore. The metadata was only fixed recently in https://github.com/microsoft/onnxruntime/releases/tag/v1.24.4 (see microsoft/onnxruntime#27354).Although this does not cause issues when updating the lock file, it creates issues when it has to be fully regenerated which e.g. happens in #771 .
It is thus necessary to pin the used version of
onnxruntimefor python 3.10.