Draft
Conversation
pagination
sergiusnick
force-pushed
the
pagination
branch
from
cc33def to
2a806ef
Compare
|
使用PageNumberPagination抛出了django.core.exceptions.SynchronousOnlyOperation异常 |
Owner
|
@sergiusnick Thanks for your contribution. I need some time to review this, would it be possible for you to add a few test cases? Thanks again. |
mateenkasim
reviewed
Oct 17, 2025
| self.display_page_controls = True | ||
|
|
||
| if self.count == 0 or self.offset > self.count: | ||
| return [] |
There was a problem hiding this comment.
I've used this implementation of LimitOffsetPagination successfully. The only change I needed was to this empty response so you can always use async for on it.
Suggested change
| return [] | |
| return queryset.none() |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#51