Fix test on MacOS, fix broken pom.xml, attach classes in .jar alongside .war#1
Open
mattsheppard wants to merge 37 commits intoellipsisnl:masterfrom
Open
Fix test on MacOS, fix broken pom.xml, attach classes in .jar alongside .war#1mattsheppard wants to merge 37 commits intoellipsisnl:masterfrom
mattsheppard wants to merge 37 commits intoellipsisnl:masterfrom
Conversation
added 7 commits
August 22, 2018 11:28
…f classes alongside the war
Author
|
bee07d1 might be of more interest - CyberDuck was giving me lots of 500 errors which boiled down to multiple threads calling parse on the same DocumentBuilder instance. |
This fixes a bug where if an exception was thrown for the top level path being deleted, all recorded errors would be ignored and a 500 would be thrown because the exception would not be caught correctly. This fixes that so that when delete is called on the top level path and an exception is raised we record that exception (like we do for the other exceptions) and correctly return the exception with the correct HTTP status code rather than always a 500.
This fixes a bug where an exception during delete might return a 500
It should have a path separator between the path and the child.
…ete-response Fixes the paths in the multi status error delete response.
We found a bunch of cases where clients did not unlock (seemingly MacOS's webdav mounting somehow). In our application we don't really care about the locks in practice, so best to have time timeout very quickly.
RNDSUPPORT-3258 - Fix XXE Vulnerability in PROPFIND
UploadedFileRejectedException added
FUN-15544 fix webdav locking issues in macos
FUN-15544 use getTempLockedObjectByPath
FUN-15544 do not use temporary locks for macos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you're interested in these changes I made while getting PfxWebDAVServer working on MacOS - Happy to discuss if anything is surprising. I'm a bit confused by at least the spring-web dependency, because a bunch of non-test classes seem to use Spring's HTTPStatus class, so it seems like it should not be working for anyone as is.