Conversation
Co-authored-by: peterjaap <431360+peterjaap@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix invalid identifier issue for DOMAINSUFFIX
Fix DOMAINSUFFIX being set to Mar 13, 2026
echo "Finished"; when running via curl | bash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the install script via
curl | bash, thedev setupscript'ssuffix()function reads from stdin to prompt for DOMAINSUFFIX. Since bash is also reading the script from that same stdin pipe,dev setupconsumes the remaining unread script bytes — ending up withecho "Finished";stored as the DOMAINSUFFIX value.The root cause:
DOMAINSUFFIX=.localhostwas prefixed toegrep(the first command in the pipeline), not todev setup. In shell,VAR=value cmdscopes the variable only to that command, sodev setupnever received it and fell back toread.Change
Move
DOMAINSUFFIX=.localhostfromegreptodev setup:With
DOMAINSUFFIXset in its environment,dev setup'ssuffix()function short-circuits and skips theread, writingDOMAINSUFFIX=.localhostcorrectly to.env.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.