Skip to content

Actions: Colorize font formatting icons at 16px#1289

Draft
newhoa wants to merge 1 commit intoelementary:mainfrom
newhoa:actions-colorize-font-formatting
Draft

Actions: Colorize font formatting icons at 16px#1289
newhoa wants to merge 1 commit intoelementary:mainfrom
newhoa:actions-colorize-font-formatting

Conversation

@newhoa
Copy link
Collaborator

@newhoa newhoa commented Jun 9, 2024

Colorize font formatting icons for better visibility under dark themes. Use semi-transparent borders,
Update font to Inter-V.

Add missing FD.o icons format-text-direction-*


Initial proposal on these, feedback would be appreciated.

Questions

  1. Should this also be done for the existing 24px icons, or are they even needed? (I really see almost no places where these are used anyway)
  2. Would it be better to use B I U and S, which have become more common in editors, chat programs, etc. These are also currently used for the symbolic icons.

Thanks.

Colorize font formatting icons for better visibility
under dark themes. Use semi-transparent borders,
Update font to Inter-V.
@micahilbery
Copy link
Member

I think it would be better to use B, U, and S. I think the a (a, a, a) alone is harder to understand for english speakers where those things start with those letters and no more clear for non-english speakers. Also the consistency with the symbolics is a good thing as well.

@newhoa newhoa marked this pull request as draft September 18, 2024 21:57
@newhoa newhoa marked this pull request as draft September 18, 2024 21:57
@kurisubrooks
Copy link

The current black/grey coloured icons are difficult to see when using a dark mode/theme in apps like LibreOffice, so the blue colour of these icons in this PR are a great change and will definitely improve visual clarity.
dark mode screenshot of bold/italic/underline/strikethrough buttons in LibreOffice Writer 26.2

I also agree with the above comment from @micahilbery, where there's a good opportunity to further improve clarity in the meaning of the icons by representing B (Bold), U (Underline) and S (Strikethrough) as their lettered counterparts, but this may be out of scope for this PR.

^ For reference, LibreOffice's implementation of the elementary icon set also uses this system of representation.
light mode screenshot of bold/italic/underline/strikethrough buttons in LibreOffice Writer 26.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants