Draft
Conversation
Use semi-transparent borders, use gradient for fill, add highlight inset border, adjust rounded edges to match curves of other similar action icons.
Contributor
|
IMHO the current version has better contrast; not sure the highlight is a net positive. No opinion on the other changes, though I welcome improved sharpness in dark mode :) |
danirabbit
requested changes
Jul 17, 2023
Member
The border is a big improvement, but I agree. I think they are too pointy now and I also agree that they should be more contrasty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Use semi-transparent borders, use gradient for fill, add highlight inset border, adjust rounded edges to match curves of other similar action icons. Should look a little smoother. And sharper on dark backgrounds.
Current:

Proposed:
