Open
Conversation
t3chguy
reviewed
Mar 26, 2026
| * The value a variable or tag can take for a translation interpolation. | ||
| * @public | ||
| */ | ||
| export type SubstitutionValue = number | string | ReactNode | ((sub: string) => ReactNode); |
Comment on lines
61
to
+72
| /** | ||
| * Perform a translation, with optional variables | ||
| * @param key - The key to translate | ||
| * @param variables - Optional variables to interpolate into the translation | ||
| */ | ||
| translate(this: void, key: keyof Translations, variables?: Variables): string; | ||
| /** | ||
| * Perform a translation, with optional variables | ||
| * @param key - The key to translate | ||
| * @param variables - Optional variables to interpolate into the translation | ||
| * @param tags - Optional tags to interpolate into the translation | ||
| */ |
Member
There was a problem hiding this comment.
Feels a bit duplicative to have most of the doc doubled up
Member
Author
There was a problem hiding this comment.
Yep but if i don't the line is commented as undocumented in the generated api:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tags support to i18n api to be able to use tags in shared components i18n api
Supported in https://github.com/element-hq/element-web/blob/develop/packages/shared-components/src/utils/i18n.tsx#L171-L178