Skip to content

Update stale screenshots playwright reporter #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
t3chguy wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update stale screenshots playwright reporter #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/element-web-playwright-common/src/stale-screenshot-reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const ANNOTATION = "_screenshot";
class StaleScreenshotReporter implements Reporter {
private readonly snapshotRoots = new Set<string>();
private readonly screenshots = new Set<string>();
private failing = false;
private readonly failing = new Set<string>();
private success = true;

public onBegin(config: FullConfig): void {
Expand All @@ -36,8 +36,11 @@ class StaleScreenshotReporter implements Reporter {

public onTestEnd(test: TestCase): void {
if (!test.ok()) {
this.failing = true;
this.failing.add(test.id);
return;
}
this.failing.delete(test.id); // delete if passed on re-run

for (const annotation of test.annotations) {
if (annotation.type === ANNOTATION && annotation.description) {
this.screenshots.add(annotation.description);
Expand All @@ -54,7 +57,10 @@ class StaleScreenshotReporter implements Reporter {
}

public async onExit(): Promise<void> {
if (this.failing) return;
if (this.failing.size) {
console.error(`${this.failing.size} tests failed, skipping stale screenshot reporter.`);
}

if (!this.snapshotRoots.size) {
this.error("No snapshot directories found, did you set the snapshotDir in your Playwright config?", "");
return;
Expand Down