Restricted Guests Synapse module: Fix the check_codestyle tox job by bumping flake8 from 4.0.1 -> 7.3.0#186
Open
anoadragon453 wants to merge 1 commit intoelement-hq:mainfrom
Open
Conversation
Member
|
Looks like a dup of #101 - why 7.1.1 over 7.3.0 ooi? |
7.3.0 is the latest version at the time of writing.
a5cc2fb to
8caed92
Compare
check_codestyle tox job by bumping flake8 from 4.0.1 -> 7.1.1check_codestyle tox job by bumping flake8 from 4.0.1 -> 7.3.0
Member
Author
So it is 🤦 Feel free to pick your favourite! |
Member
|
/me is unable to review either so is free of any decision making here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we get this cryptic error when trying to lint the Restricted Guests Synapse module:
Bumping the
flake8version fixes this, with no code style changes needed.