Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very much a work-in-progress, but I am opening it up so we have a centralized place to discuss these things that's not my PR.
To briefly give my personal answers to the questions posed:
protocol.handlemeant, by us, to be an middleware-like interception API or a provider API for thehttpsscheme? Not sure, I didn't make it.protocol.handlebe split into two different API's (e.g.protocol.handleandprotocol.intercept)? Splitting might be better, if we want to support more middleware-like features.Set-Cookieheader in a returned response set the cookies? Would be nice in concept, hard to implement (when and where would the API commit to applying the cookies?).webRequesthandlers API? Perhaps deprecated if their behavior can be superseded by any new API?