Skip to content

ci: fix check-sdk-version.js #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarshallOfSound merged 1 commit into from
Apr 8, 2026
Merged

ci: fix check-sdk-version.js #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/check-sdk-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,16 @@ jobs:
- name: Install dependencies
run: yarn install --frozen-lockfile

- name: Build
run: yarn build

- name: Fetch Chromium mac_toolchain.py
run: |
curl -sSL "https://chromium.googlesource.com/chromium/src/+/main/build/mac_toolchain.py?format=TEXT" | base64 -d > mac_toolchain.py

- name: Check for new SDK version
id: check-sdk
run: node .github/workflows/scripts/check-sdk-version.js mac_toolchain.py
run: node .github/workflows/scripts/check-sdk-version.mjs mac_toolchain.py

- name: Create issue for new SDK
if: steps.check-sdk.outputs.new-sdk == 'true'
Expand Down
15 changes: 5 additions & 10 deletions ...ub/workflows/scripts/check-sdk-version.js → ...b/workflows/scripts/check-sdk-version.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
#!/usr/bin/env node

const fs = require('fs');
const path = require('path');
const { extractSDKVersion } = require('../../../src/utils/sdk');
import * as fs from 'node:fs';

function getKnownSDKs() {
const sdkPath = path.resolve(__dirname, '../../../src/utils/sdks.json');
const sdks = JSON.parse(fs.readFileSync(sdkPath, 'utf8'));
return Object.keys(sdks);
}
import { extractSDKVersion } from '../../../dist/utils/sdk.js';
import SDKs from '../../../src/utils/sdks.json' with { type: 'json' };

function isNewerVersion(v1, v2) {
const [major1, minor1] = v1.split('.').map(Number);
Expand All @@ -26,7 +21,7 @@ function main() {

if (!macToolchainPath || !fs.existsSync(macToolchainPath)) {
console.error(`Error: Could not find ${macToolchainPath || 'mac_toolchain.py'}`);
console.error('Usage: node check-sdk-version.js <path-to-mac_toolchain.py>');
console.error('Usage: node check-sdk-version.mjs <path-to-mac_toolchain.py>');
process.exit(1);
}

Expand All @@ -38,7 +33,7 @@ function main() {
process.exit(1);
}

const knownSDKs = getKnownSDKs();
const knownSDKs = Object.keys(SDKs);
console.log(`Known SDK versions: ${knownSDKs.join(', ')}`);

if (knownSDKs.includes(chromiumSDK)) {
Expand Down