Skip to content

lib: remove incorrect period scaling#119

Merged
efd6 merged 2 commits intodevfrom
117-dimensionally-wrong
Jan 21, 2026
Merged

lib: remove incorrect period scaling#119
efd6 merged 2 commits intodevfrom
117-dimensionally-wrong

Conversation

@efd6
Copy link
Collaborator

@efd6 efd6 commented Jan 19, 2026

A dimensional analysis would have shown this to be incorrect; per is the period over which the rate value is applied and so should be in s, but this makes it in s², giving a rate in s¯².

Please take a look.

Fixes #117.

A dimensional analysis would have shown this to be incorrect; per is the
period over which the rate value is applied and so should be in s, but
this makes it in s², giving a rate in s¯².
@efd6 efd6 self-assigned this Jan 19, 2026
@efd6 efd6 added bug Something isn't working Team:Security-Service Integrations labels Jan 19, 2026
@efd6 efd6 requested a review from a team January 19, 2026 20:19
@efd6 efd6 force-pushed the 117-dimensionally-wrong branch from 8a6b819 to ff274f8 Compare January 19, 2026 21:54
@efd6 efd6 merged commit d0d2dba into dev Jan 21, 2026
4 checks passed
efd6 added a commit to efd6/beats that referenced this pull request Jan 21, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling.

ref: elastic/mito#119
efd6 added a commit to efd6/beats that referenced this pull request Jan 21, 2026
This picks up elastic/mito@d017a1f which fixes rate period scaling.

ref: elastic/mito#119
efd6 added a commit to efd6/beats that referenced this pull request Jan 21, 2026
This picks up elastic/mito@d017a1f which fixes rate period scaling.

ref: elastic/mito#119
efd6 added a commit to elastic/beats that referenced this pull request Jan 23, 2026
mergify bot pushed a commit to elastic/beats that referenced this pull request Jan 23, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling.

ref: elastic/mito#119
(cherry picked from commit c17c95d)

# Conflicts:
#	NOTICE.txt
#	docs/reference/filebeat/filebeat-input-cel.md
#	go.mod
#	go.sum
mergify bot pushed a commit to elastic/beats that referenced this pull request Jan 23, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling.

ref: elastic/mito#119
(cherry picked from commit c17c95d)

# Conflicts:
#	go.mod
cmacknz pushed a commit to elastic/beats that referenced this pull request Jan 23, 2026
efd6 added a commit to elastic/beats that referenced this pull request Jan 24, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling.

ref: elastic/mito#119
(cherry picked from commit c17c95d)
efd6 added a commit to elastic/beats that referenced this pull request Jan 24, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling.

ref: elastic/mito#119
(cherry picked from commit c17c95d)
efd6 added a commit to elastic/beats that referenced this pull request Jan 24, 2026
…#48526)

This picks up elastic/mito@cf9d7cc which fixes rate period scaling.

ref: elastic/mito#119

(cherry picked from commit c17c95d)

---------

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6 added a commit to elastic/beats that referenced this pull request Jan 25, 2026
This picks up elastic/mito@f9b0830 which fixes rate period scaling.

ref: elastic/mito#119
(cherry picked from commit c17c95d)

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
brijesh-elastic added a commit to elastic/integrations that referenced this pull request Feb 27, 2026
The httpjson input's limitPolicy function in mito incorrectly scaled
the rate period by the window duration, producing a rate in s^-2
instead of s^-1. This made rate limiting far more restrictive than
the server's headers indicated for any window > 1s. The fix landed
in mito v1.22.1, v1.23.1, and v1.24.1, which were picked up in
beats v8.19.11 (elastic/beats#48500) and v9.2.5
(elastic/beats#48526). Bump the Kibana version constraint to match.

ref: elastic/mito#119
ilyannn pushed a commit to elastic/integrations that referenced this pull request Feb 28, 2026
The httpjson input's limitPolicy function in mito incorrectly scaled
the rate period by the window duration, producing a rate in s^-2
instead of s^-1. This made rate limiting far more restrictive than
the server's headers indicated for any window > 1s. The fix landed
in mito v1.22.1, v1.23.1, and v1.24.1, which were picked up in
beats v8.19.11 (elastic/beats#48500) and v9.2.5
(elastic/beats#48526). Bump the Kibana version constraint to match.

ref: elastic/mito#119
navnit-elastic pushed a commit to navnit-elastic/integrations that referenced this pull request Mar 2, 2026
…tic#17564)

The httpjson input's limitPolicy function in mito incorrectly scaled
the rate period by the window duration, producing a rate in s^-2
instead of s^-1. This made rate limiting far more restrictive than
the server's headers indicated for any window > 1s. The fix landed
in mito v1.22.1, v1.23.1, and v1.24.1, which were picked up in
beats v8.19.11 (elastic/beats#48500) and v9.2.5
(elastic/beats#48526). Bump the Kibana version constraint to match.

ref: elastic/mito#119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible rate calculation issue in limitPolicy function

2 participants