Skip to content

fix(qualys_vmdr): use join for ID_SET in KB response error path#17932

Open
andrewkroh wants to merge 1 commit intoelastic:mainfrom
andrewkroh:fix/qualys_vmdr/no-such-overload-rate-limit-chain
Open

fix(qualys_vmdr): use join for ID_SET in KB response error path#17932
andrewkroh wants to merge 1 commit intoelastic:mainfrom
andrewkroh:fix/qualys_vmdr/no-such-overload-rate-limit-chain

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Mar 20, 2026

Proposed commit message

The CEL expression at line 244 calls string() on the result
of ID_SET.orValue([]) which is a list. When the knowledge
base API response is missing expected ID values, this path
triggers string(list) which has no overload.

Replace string() with join(" ") to properly convert the list
to a string for the error message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@andrewkroh andrewkroh force-pushed the fix/qualys_vmdr/no-such-overload-rate-limit-chain branch from 2ecb88e to 350ad89 Compare March 20, 2026 15:56
@andrewkroh andrewkroh added Integration:snyk Snyk Integration:qualys_vmdr Qualys VMDR Integration:qualys_gav Qualys Global AssetView bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Mar 20, 2026
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 20, 2026

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh marked this pull request as ready for review March 20, 2026 16:34
@andrewkroh andrewkroh requested a review from a team as a code owner March 20, 2026 16:34
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkroh andrewkroh marked this pull request as draft March 20, 2026 19:02
@andrewkroh andrewkroh changed the title fix(qualys_vmdr,qualys_gav,snyk): use optional index for header access fix(qualys_vmdr,qualys_gav,snyk): use map and join for rate limit header access Mar 20, 2026
@andrewkroh andrewkroh force-pushed the fix/qualys_vmdr/no-such-overload-rate-limit-chain branch 2 times, most recently from 19d8105 to 2c40c2a Compare March 20, 2026 19:10
@andrewkroh andrewkroh marked this pull request as ready for review March 20, 2026 19:12
error path

The CEL expression at line 244 calls string() on the result
of ID_SET.orValue([]) which is a list. When the knowledge
base API response is missing expected ID values, this path
triggers string(list) which has no overload.

Replace string() with join(" ") to properly convert the list
to a string for the error message.
@andrewkroh andrewkroh force-pushed the fix/qualys_vmdr/no-such-overload-rate-limit-chain branch from 2c40c2a to 8305f52 Compare March 20, 2026 19:31
@andrewkroh andrewkroh changed the title fix(qualys_vmdr,qualys_gav,snyk): use map and join for rate limit header access fix(qualys_vmdr): use join for ID_SET in KB response error path Mar 20, 2026
@andrewkroh andrewkroh removed Integration:snyk Snyk Integration:qualys_gav Qualys Global AssetView labels Mar 20, 2026
@elasticmachine
Copy link

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:qualys_vmdr Qualys VMDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants