[Watchguard]: Pipeline failure on traffic logs#17908
Open
qcorporation wants to merge 3 commits intomainfrom
Open
[Watchguard]: Pipeline failure on traffic logs#17908qcorporation wants to merge 3 commits intomainfrom
qcorporation wants to merge 3 commits intomainfrom
Conversation
Contributor
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
andrewkroh
added
documentation
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
andrewkroh
added
the
Team:Integration-Experience
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
Comment on lines
+1150
to
+1154
| && ctx.watchguard_firebox?.log?.destination_ip != null | ||
| && ctx.watchguard_firebox?.log?.source_port != null | ||
| && ctx.watchguard_firebox.log.source_port != 0 | ||
| && ctx.watchguard_firebox?.log?.destination_port != null | ||
| && ctx.watchguard_firebox.log.destination_port != 0 |
Contributor
There was a problem hiding this comment.
Remaining ? are probably redundant and can be removed.
Also, it's odd to me that we are running it against the vendor fields and not the ECS fields...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ingest pipeline failures on ESP traffic logs where community_id ran with missing or zero ports (Painless treats null != 0 as true).
Changes
pipeline_traffic.yml: Tighten the community_id processor if so it only runs when source/destination IP and ports are present and ports are non-zero.
fields.yml: Add watchguard_firebox.log.geo_src (keyword) so pipeline output from KV-parsed geo_src="..." passes field validation.
Tests
Append an ESP traffic sample to test-traffic.log; regenerate test-traffic.log-expected.json with elastic-package test pipeline --generate.
Checklist
changelog.ymlfile.Related issues
Bumps package to 1.6.2 (changelog: bugfix).