Adds demo video links to SentinelOne, Crowdstrike, Microsoft Defender XDR, and Microsoft Defender Endpoint #17889
Adds demo video links to SentinelOne, Crowdstrike, Microsoft Defender XDR, and Microsoft Defender Endpoint #17889jmikell821 wants to merge 3 commits intomainfrom
Conversation
|
Please run these commands to update changelogs and build docs: for pkg in crowdstrike m365_defender microsoft_defender_endpoint sentinel_one; do
cd packages/$pkg
elastic-package changelog add --type enhancement --description "Improve documentation" --link "https://github.com/elastic/integrations/pull/17889" --next minor
elastic-package build
cd ../..
done
git add -u
git commit -m "docs: update changelogs and build documentation"
git pushPrerequisite: |
Vale Linting ResultsSummary: 2 suggestions found 💡 Suggestions (2)
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
🚀 Benchmarks reportTo see the full report comment with |
|
+CC @KOTungseth since we had a convo on videos in docs already. |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
💚 Build Succeeded
History
cc @jmikell821 |
karenzone
left a comment
There was a problem hiding this comment.
LGTM.
Suggestions for discussion and later consideration (not blocking):
- Consider less formal wording for intros.
- Add duration. Users are more likely to engage and watch the whole video when they know ahead of time how much time they are investing.
Something like " Check out this demo. (Duration:13:55)"
| # newer versions go on top | ||
| - version: "2.5.0" | ||
| changes: | ||
| - description: Improve documentation |
There was a problem hiding this comment.
| - description: Improve documentation | |
| - description: Add demo video link to integration documentation. |
| # newer versions go on top | ||
| - version: "4.5.0" | ||
| changes: | ||
| - description: Improve documentation |
There was a problem hiding this comment.
| - description: Improve documentation | |
| - description: Add demo video link to integration documentation. |
| # newer versions go on top | ||
| - version: "5.12.0" | ||
| changes: | ||
| - description: Improve documentation |
There was a problem hiding this comment.
| - description: Improve documentation | |
| - description: Add demo video link to integration documentation. |
| # newer versions go on top | ||
| - version: "3.12.0" | ||
| changes: | ||
| - description: Improve documentation |
There was a problem hiding this comment.
| - description: Improve documentation | |
| - description: Add demo video link to integration documentation. |
Proposed commit message
Adds demo video links to SentinelOne, Crowdstrike, Microsoft Defender XDR, and Microsoft Defender Endpoint.
Checklist
changelog.ymlfile.How to test this PR locally
Ensure the videos appear as expected.
Related issues
Closes https://github.com/elastic/docs-content-internal/issues/369
Closes https://github.com/elastic/docs-content-internal/issues/370
Closes https://github.com/elastic/docs-content-internal/issues/368