[9.3](backport #49518) perf(otel): share instance of Beat processor between pipelines#49570
Open
mergify[bot] wants to merge 1 commit into9.3from
Open
[9.3](backport #49518) perf(otel): share instance of Beat processor between pipelines#49570mergify[bot] wants to merge 1 commit into9.3from
mergify[bot] wants to merge 1 commit into9.3from
Conversation
* feat(otel): share instance of Beat processor between pipelines * test: refine test case * refactor: move sharedcomponent package * go mod tidy * fix license header (cherry picked from commit eff0889)
mergify
bot
requested review from
khushijain21 and
leehinman
and removed request for
a team
botelastic
bot
added
the
needs_team
3 tasks
Contributor
🤖 GitHub commentsJust comment with:
|
github-actions
bot
added
enhancement
Team:Elastic-Agent-Data-Plane
botelastic
bot
removed
the
needs_team
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Changes the implementation of the OTel Beat processor so that only a single instance is created for a single configuration. This is done by re-using sharedcomponent package from OpenTelemetry Collector (the package source had to be copied as it is a private package upstream, see open-telemetry/opentelemetry-collector#4266, open-telemetry/opentelemetry-collector#11622)).
Previously a separate instance was created for every pipeline the processor was used in.
This saves resources by avoiding duplicate instances of expensive Beat processors like
add_kubernetes_metadata, etc.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesstresstest.shscript to run them under stress conditions and race detector to verify their stability.[ ] I have added an entry in./changelog/fragmentsusing the changelog tool.How to test this PR locally
Build Elastic Agent with this change, run with a config similar to the one specified in the
TestBeatProcessorSharedAcrossPipelinestest in this PR.This is an automatic backport of pull request #49518 done by [Mergify](https://mergify.com).