Skip to content

fix(ci): artifact@v3 -> artifact@v4 #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wdconinc merged 1 commit into from
Jan 21, 2026
Merged

fix(ci): artifact@v3 -> artifact@v4 #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
echo "[CI] build epic-analysis"
source environ.sh
make ${{matrix.recipe}}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: x_build_${{matrix.recipe}}
retention-days: 1
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
echo "[CI] build epic-analysis"
source environ.sh
EXCLUDE_DELPHES=1 make release
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: x_build_no_delphes
retention-days: 1
Expand Down Expand Up @@ -124,7 +124,7 @@ jobs:
--output ci \
--config datarec/ci/delphes_${{matrix.id}}.config \
${{matrix.options}}
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: x_fastsim_delphes
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The delphes_fastsim job has a matrix with 4 parallel runs that all upload to the same artifact name "x_fastsim_delphes". In upload-artifact@v4, artifacts with the same name will overwrite each other instead of merging like in v3. You need to make artifact names unique per matrix job by including the matrix variable in the name, for example: "x_fastsim_delphes_${{matrix.id}}"

Suggested change
name: x_fastsim_delphes
name: x_fastsim_delphes_${{matrix.id}}

Copilot uses AI. Check for mistakes.
retention-days: 1
Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:
${{matrix.options}}
echo "[CI] cat config file"
cat s3files.config
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: x_fullsim_${{matrix.id}}
retention-days: 1
Expand Down Expand Up @@ -194,10 +194,10 @@ jobs:
- { aname: x_q2, recon: eSigma }
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: x_build_release
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: x_fastsim_delphes
path: x_fastsim_delphes
Expand All @@ -220,7 +220,7 @@ jobs:
cat delphes.config
echo "[CI] ANALYSIS MACRO"
${{env.root}} 'macro/ci/analysis_${{matrix.aname}}.C("delphes.config","fastsim.${{matrix.aname}}.${{matrix.recon}}","${{matrix.recon}}")'
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: analysis
retention-days: 7
Expand Down Expand Up @@ -265,10 +265,10 @@ jobs:
- { aname: x_q2, recon: eSigma, detector: ecce }
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: x_build_no_delphes
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: x_fullsim_${{matrix.detector}}
- uses: cvmfs-contrib/github-action-cvmfs@v3
Expand All @@ -287,7 +287,7 @@ jobs:
cat s3files.config
echo "[CI] ANALYSIS MACRO"
${{env.root_no_delphes}} 'macro/ci/analysis_${{matrix.aname}}.C("s3files.config","${{matrix.detector}}.${{matrix.aname}}.${{matrix.recon}}","${{matrix.recon}}")'
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: analysis
retention-days: 7
Expand Down Expand Up @@ -357,10 +357,10 @@ jobs:
- { mode: ecce, pname: coverage2D_x_q2, recon: Sigma, aname: x_q2, pmacro: postprocess_x_q2.C }
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: x_build_no_delphes
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: analysis
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This download step expects to download the "analysis" artifact, but since the analysis_fastsim and analysis_fullsim jobs will need to upload with unique artifact names per matrix job (due to v4 requirements), this download step will also need to be updated to download all the individual artifacts using a pattern or merge approach. Consider using actions/download-artifact@v4 with the merge-multiple option or downloading each artifact individually.

Suggested change
name: analysis
pattern: analysis*
merge-multiple: true

Copilot uses AI. Check for mistakes.
path: out
Expand All @@ -381,7 +381,7 @@ jobs:
mv -v out/${{matrix.mode}}.{${{matrix.aname}},${{matrix.pname}}}.${{matrix.recon}}.root # rename aname -> pname
${{env.root_no_delphes}} 'macro/ci/${{matrix.pmacro}}("out/${{matrix.mode}}.${{matrix.pname}}.${{matrix.recon}}.root")'
rm -v out/${{matrix.mode}}.${{matrix.pname}}.${{matrix.recon}}.root # rm analysis_root artifact
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: postprocess
retention-days: 30
Expand Down Expand Up @@ -425,10 +425,10 @@ jobs:
- { pname: coverage_x_q2, recon: eSigma, aname: x_q2, xvar: x, yvar: q2 }
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: x_build_no_delphes
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: analysis
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This download step expects to download the "analysis" artifact, but since the analysis_fastsim and analysis_fullsim jobs will need to upload with unique artifact names per matrix job (due to v4 requirements), this download step will also need to be updated to download all the individual artifacts using a pattern or merge approach. Consider using actions/download-artifact@v4 with the merge-multiple option or downloading each artifact individually.

Suggested change
name: analysis
pattern: analysis-*
merge-multiple: true

Copilot uses AI. Check for mistakes.
path: out
Expand Down Expand Up @@ -458,7 +458,7 @@ jobs:
# "ATHENA" "athena" \
# "ECCE" "ecce" \
# "LEGACY"
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: comparison
retention-days: 30
Expand All @@ -476,11 +476,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: postprocess
path: results
Comment on lines +479 to 482
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This download step expects to download the "postprocess" artifact, but since the postprocess job will need to upload with unique artifact names per matrix job (due to v4 requirements), this download step will also need to be updated to download all the individual artifacts using a pattern or merge approach. Consider using actions/download-artifact@v4 with the merge-multiple option or downloading each artifact individually.

Copilot uses AI. Check for mistakes.
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: comparison
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This download step expects to download the "comparison" artifact, but since the comparison job will need to upload with unique artifact names per matrix job (due to v4 requirements), this download step will also need to be updated to download all the individual artifacts using a pattern or merge approach. Consider using actions/download-artifact@v4 with the merge-multiple option or downloading each artifact individually.

Suggested change
name: comparison
pattern: comparison-*
merge-multiple: true

Copilot uses AI. Check for mistakes.
path: results
Expand Down Expand Up @@ -512,7 +512,7 @@ jobs:
ecce \
athena
tree results
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
retention-days: 90
name: _FULL_RESULTS
Expand Down
Loading