Added Controls in advance settings of video xblock in CMS to enable/d…#239
Open
naumanshafi wants to merge 2 commits intocme-developfrom
Open
Added Controls in advance settings of video xblock in CMS to enable/d…#239naumanshafi wants to merge 2 commits intocme-developfrom
naumanshafi wants to merge 2 commits intocme-developfrom
Conversation
ziafazal
requested changes
May 27, 2021
Member
ziafazal
left a comment
ziafazal
left a comment
There was a problem hiding this comment.
@naumanshafi @rehanfarooq123 completed another round of review.
common/lib/xmodule/xmodule/js/src/video/06_video_progress_slider.js
Outdated
Show resolved
Hide resolved
ziafazal
requested changes
Jun 1, 2021
Member
ziafazal
left a comment
ziafazal
left a comment
There was a problem hiding this comment.
@naumanshafi could you please look into few minor things before writing unit tests?
common/lib/xmodule/xmodule/js/src/video/08_video_speed_control.js
Outdated
Show resolved
Hide resolved
ziafazal
requested changes
Jun 4, 2021
Member
ziafazal
left a comment
ziafazal
left a comment
There was a problem hiding this comment.
@naumanshafi completed review.
common/lib/xmodule/xmodule/js/src/video/09_save_state_plugin.js
Outdated
Show resolved
Hide resolved
naumanshafi
force-pushed
the
noman/video-xblock-customization
branch
2 times, most recently
from
7b6216d to
a5ed47e
Compare
naumanshafi
force-pushed
the
noman/video-xblock-customization
branch
from
a5ed47e to
a4539d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Controls/Flags in advance settings of video xblock in CMS to enable/disable progress bar and speed menu of video component and to enable/disable next button in LMS. Also added is_complete flag in VideoFields to persist completion status of video.