Skip to content

Fix Cray ctest by fixing link options#136

Closed
DJDavies2 wants to merge 2 commits intoecmwf:developfrom
DJDavies2:feature/135
Closed

Fix Cray ctest by fixing link options#136
DJDavies2 wants to merge 2 commits intoecmwf:developfrom
DJDavies2:feature/135

Conversation

@DJDavies2
Copy link
Contributor

Description

Remove some invalid compile options for the Cray compiler.

Resolves #135.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@marcosbento
Copy link
Collaborator

Personally, the changes seem OK to me, but, @wdeconinck, considering the additional compilation flags affect Fortran, maybe you could have a quick look?

@wdeconinck
Copy link
Member

The issue is not with the cray compiler but with the test itself. #137 should be the proper fix here.

@wdeconinck wdeconinck closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ctest failure in test_ecbuild_override_compiler_flags for cray compiler

3 participants