Skip to content

Remove Row number column in TableOverview #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TruongQuangSB wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove Row number column in TableOverview #2294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...set.feature.table/src/org/eclipse/set/feature/table/overview/TableErrorTableColumns.xtend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import org.eclipse.set.nattable.utils.AbstractColumns
class TableErrorTableColumns extends AbstractColumns {
public final ColumnDescriptor Index;
public final ColumnDescriptor LeadingObject;
public final ColumnDescriptor RowNumber;
public final ColumnDescriptor Source;
public final ColumnDescriptor TableType;
public final ColumnDescriptor Message;
Expand All @@ -37,7 +36,6 @@ class TableErrorTableColumns extends AbstractColumns {
TableType = createNew(messages.TableErrorTableColumns_TableType)
LeadingObject = createNew(messages.TableErrorTableColumns_LeadingObject)
Message = createNew(messages.TableErrorTableColumns_Message)
RowNumber = createNew(messages.TableErrorTableColumns_RowNumber)

}

Expand All @@ -47,9 +45,8 @@ class TableErrorTableColumns extends AbstractColumns {
root.add(Index).widthPercent(5)
root.add(Source).widthPercent(5)
root.add(TableType).widthPercent(8)
root.add(RowNumber).widthPercent(7)
root.add(LeadingObject).widthPercent(15)
root.add(Message).widthPercent(50)
root.add(Message).widthPercent(57)
return root.getGroupRoot()
}
}
3 changes: 1 addition & 2 deletions ...ature.table/src/org/eclipse/set/feature/table/overview/TableErrorTableTransformator.xtend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,14 @@ class TableErrorTableTransformator extends AbstractTableModelTransformator<Colle
TMFactory factory) {
val Comparator<TableError> comparator = Comparator.comparing [ TableError it |
source
].thenComparing[TableError it | containerType].thenComparing[TableError it|rowNumber]
].thenComparing[TableError it | containerType]
errors.sortWith(comparator).forEach [ error, index |
val instance = factory.newTableRow(error)
fill(instance, columns.Index, index, [(index + 1).toString])
fill(instance, columns.Source, error, [error.source])
fill(instance, columns.TableType, error, [
enumTranslationService.translate(error.containerType).presentation
])
fill(instance, columns.RowNumber, error, [error.rowNumber])
fill(instance, columns.LeadingObject, error, [error.getErrorIdentifier])
fill(instance, columns.Message, error, [error.message])
]
Expand Down
8 changes: 0 additions & 8 deletions java/bundles/org.eclipse.set.utils.table/src/org/eclipse/set/utils/table/TableError.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import org.eclipse.set.model.planpro.Basisobjekte.Ur_Objekt;
import org.eclipse.set.model.planpro.Basisobjekte.impl.Ur_ObjektImpl;
import org.eclipse.set.model.tablemodel.TableRow;
import org.eclipse.set.model.tablemodel.extensions.TableRowExtensions;
import org.eclipse.set.ppmodel.extensions.EObjectExtensions;

/**
Expand Down Expand Up @@ -102,13 +101,6 @@ public String getMessage() {
return message;
}

/**
* @return the row number where the error occurred
*/
public String getRowNumber() {
return String.valueOf(TableRowExtensions.getTrueRowIndex(row) + 1);
}

/**
* @return the container type of leading object
*/
Expand Down
Loading