Launch Manager supports the new configuration format by NicolasFussberger · Pull Request #110 · eclipse-score/lifecycle

NicolasFussberger · 2026-03-10T14:18:59Z

Summary

This PR introduces a mapping of the new configuration schema to the existing configuration format. Therefore, allowing users to configure the launch_manager using the simpler configuration format. This approach is depicted here.

The configuration interface is a bazel function that validates the json configuration, maps the new configuration content to the existing configuration files that are in use by the C++ implementation. Note: This PR is not yet adapting the C++ code to load the new configuration directly, but instead it maps the new configuration to the old configuration format so the existing code keeps working as-is.

Usage Example from the reference_integration perspective:

load("@score_lifecycle_health//:defs.bzl", "launch_manager_config")
launch_manager_config(
    name ="lifecycle_configs",
    config="//showcases/simple_lifecycle/configs:launch_manager_config.json"
)

Details

Introduces bazel function launch_manager_config, allowing users to easily make use of the new configuration
Introduces an internal mapping script in python lifecycle_config.py, taking as input the new configuration file and generating as output the same content in the existing configuration format (i.e. mapping of RunTarget -> ProcessGroup States). See the Readme at scripts/config_mapping/Readme.md for details
Adapt the ControlClient API to change RunTarget instead of ProcessGroup States (internal mapping to ProcessGroup States)
Adapt existing examples and smoketest to use the new configuration format

Closes: #38

…g_mapper

github-actions · 2026-03-10T14:19:55Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: b949cf98-1998-4493-8d65-12ff4ae48af5
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (54 packages loaded, 9 targets configured)

Analyzing: target //:license-check (89 packages loaded, 9 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2642 targets configured)

Analyzing: target //:license-check (153 packages loaded, 6208 targets configured)

Analyzing: target //:license-check (156 packages loaded, 7855 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7895 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (166 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (169 packages loaded, 9913 targets configured)

INFO: Analyzed target //:license-check (170 packages loaded, 10039 targets configured).
[11 / 16] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[15 / 16] [Prepa] Building license.check.license_check.jar ()
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 26.364s, Critical Path: 2.51s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-03-10T14:23:16Z

The created documentation from the pull request is available at: docu-html

…er-unverified

pawelrutkaq

The JSON files as test files are a bit bloat, maintaining them may be harsh. Maybe it would be better to have that in code and copose configs from well defined pieces.

nothing worrying, but next time it would be good to keep PR smaller.

pawelrutkaq · 2026-03-18T13:09:58Z

src/launch_manager_daemon/config/config_schema/BUILD

+#
+# SPDX-License-Identifier: Apache-2.0
+# *******************************************************************************
+exports_files(["s-core_launch_manager.schema.json"])


lets remove s-core from name. makse no sens imho. and it even wors with - and _ mixup

How about we move the renaming to the other open PR regarding configuration schema then it can directly be changed consistently everywhere

pawelrutkaq · 2026-03-18T13:21:06Z

src/control_client_lib/src/control_client.cpp


-ControlClient::ControlClient(std::function<void(const score::lcm::ExecutionErrorEvent&)> undefinedStateCallback) noexcept {
+ControlClient::ControlClient() noexcept {
+    static std::function<void(const score::lcm::ExecutionErrorEvent&)> undefinedStateCallback = [](const score::lcm::ExecutionErrorEvent& event) {};


why static fn and not simply lambda ?

I guess lambda is equally fine. I can change it to lambda if you prefer that.
The idea here was merely to hardcode this callback to an empty callback for now to align the interface with the existing documentation.
After further discussion on how the API should look like, we can then either delete this or refactor.

pawelrutkaq · 2026-03-18T13:34:43Z

examples/run_examples.bzl

+#
+# SPDX-License-Identifier: Apache-2.0
+# *******************************************************************************
+def _impl_run_examples(ctx):


why we just dont use sh_ or genrule ?

Got rid of bzl file and replaced it with sh_binary

NicolasFussberger · 2026-03-20T09:30:47Z

The JSON files as test files are a bit bloat, maintaining them may be harsh. Maybe it would be better to have that in code and copose configs from well defined pieces.

nothing worrying, but next time it would be good to keep PR smaller.

Regarding the JSON files. I agree it will not scale well. Currently, there are only few basic tests, because this configuration mapping is only temporary and the next step will be to read in the new config directly from the C++ code. I would expect we do some fine tuning of the new configuration and once we are happy we change the C++ code and the python script and its tests will all be obsolete.

pawelrutkaq · 2026-03-20T10:47:47Z

@eelcoem branch need to be up to date

eelcoem · 2026-03-20T11:36:18Z

@eelcoem branch need to be up to date

Done

NicolasFussberger · 2026-03-23T06:32:25Z

QNX x86 build fails due to download timeout, however the qnx arm build was successful.

Error in download_and_extract: java.io.IOException: Error downloading [https://www.qnx.com/download/download/79858/installation.tgz] to /home/runner/.bazel/external/score_bazel_cpp_toolchains++gcc+score_qcc_x86_64_toolchain_pkg/temp12311846832469847643/installation.tgz: Connect timed out
ERROR: no such package '@@score_bazel_cpp_toolchains++gcc+score_qcc_x86_64_toolchain_pkg//': java.io.IOException: Error downloading [https://www.qnx.com/download/download/79858/installation.tgz] to /home/runner/.bazel/external/score_bazel_cpp_toolchains++gcc+score_qcc_x86_64_toolchain_pkg/temp12311846832469847643/installation.tgz: Connect timed out

NicolasFussberger and others added 21 commits February 12, 2026 11:36

Basic python setup for mapping script

41f99ca

Add latest example configuration

f396729

Merging of default values

c49be75

Basic smoketest for defaults preprocessing

c0bcd08

Start to map PHM configuration

19776f9

Separate unit and integration tests

646f0c2

Document mapping decisions and initial known limitations

5d2c385

Copy dict only internally when merging defaults

c4afbb9

Initial mapping of hm configuration

160a624

Treat StateManager supervision same as other supervisions

c0686fc

Fix time unit and some flatbuffer schema violations

a326e02

basic Integration test for health configuration

385f47d

Better nameing of env vars in unit test

1473e90

Configs for health integration test

0214f86

Start work

6bcdeb8

Merge branch 'feature/config_mapper-unverified' into feature/lm_confi…

55aa619

…g_mapper

Almost done

ee10cbc

Add validation and update sample configs

0251016

Add health test for empty config

05e9758

Update Readme file with validation info

22446ec

Merge branch 'feature/config_mapper-unverified' into feature/lm_confi…

061ccc4

…g_mapper

NicolasFussberger requested a deployment to workflow-approval March 10, 2026 14:19 — with GitHub Actions Waiting

NicolasFussberger requested a deployment to workflow-approval March 10, 2026 14:27 — with GitHub Actions Waiting

NicolasFussberger requested a deployment to workflow-approval March 10, 2026 14:33 — with GitHub Actions Waiting

Continue config mapping script

f0c8f08

NicolasFussberger marked this pull request as ready for review March 11, 2026 10:18

Merge remote-tracking branch 'upstream/main' into feature/config_mapp…

eb4b42f

…er-unverified

NicolasFussberger temporarily deployed to workflow-approval March 11, 2026 10:29 — with GitHub Actions Inactive

FScholPer previously approved these changes Mar 13, 2026

View reviewed changes

FScholPer requested a review from pawelrutkaq March 13, 2026 15:11

anmittag added this to LCM - Lifecycle & Health FT Mar 16, 2026

github-project-automation bot moved this to Backlog in LCM - Lifecycle & Health FT Mar 16, 2026

Use defined default values in configuration mapping

680e924

paulquiring dismissed FScholPer’s stale review via 680e924 March 17, 2026 10:02

paulquiring temporarily deployed to workflow-approval March 17, 2026 10:02 — with GitHub Actions Inactive

pawelrutkaq reviewed Mar 18, 2026

View reviewed changes

FScholPer previously approved these changes Mar 19, 2026

View reviewed changes

Simplify bazel example runner

d1a8ca8

eelcoem dismissed FScholPer’s stale review via d1a8ca8 March 20, 2026 09:58

eelcoem requested a deployment to workflow-approval March 20, 2026 09:58 — with GitHub Actions Waiting

Merge branch 'main' into feature/support_new_launch_manager_config

280a67e

eelcoem had a problem deploying to workflow-approval March 20, 2026 11:36 — with GitHub Actions Failure

eelcoem had a problem deploying to workflow-approval March 20, 2026 11:36 — with GitHub Actions Error

pawelrutkaq approved these changes Mar 20, 2026

View reviewed changes

eelcoem deployed to workflow-approval March 20, 2026 12:54 — with GitHub Actions Active

eelcoem had a problem deploying to workflow-approval March 23, 2026 06:27 — with GitHub Actions Failure

NicolasFussberger merged commit 757d17d into eclipse-score:main Mar 23, 2026
18 of 22 checks passed

github-project-automation bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Mar 23, 2026

Conversation

NicolasFussberger commented Mar 10, 2026

Summary

Details

Uh oh!

github-actions bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

pawelrutkaq left a comment

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

NicolasFussberger Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

NicolasFussberger Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

eelcoem Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

NicolasFussberger commented Mar 20, 2026

Uh oh!

pawelrutkaq commented Mar 20, 2026

Uh oh!

eelcoem commented Mar 20, 2026

Uh oh!

NicolasFussberger commented Mar 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Mar 10, 2026 •

edited

Loading

NicolasFussberger Mar 20, 2026 •

edited

Loading