fix: improve ExecutorService performance and startup#12
Merged
AlexandreMunsch merged 1 commit intodevelop-3.3.5from Nov 7, 2025
Merged
fix: improve ExecutorService performance and startup#12AlexandreMunsch merged 1 commit intodevelop-3.3.5from
AlexandreMunsch merged 1 commit intodevelop-3.3.5from
Conversation
Replaces the Thread::sleep() busy-waiting loop with a std::condition_variable and std::mutex mechanism for a more efficient, low-CPU idle state. The worker thread is now started lazily on the first execute() call, avoiding unnecessary thread creation at startup. The shutdown() logic has also been updated to safely handle termination, even if the thread was never started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Thread::sleep() busy-waiting loop with a std::condition_variable and std::mutex mechanism for a more efficient, low-CPU idle state. The worker thread is now started lazily on the first execute() call, avoiding unnecessary thread creation at startup. The shutdown() logic has also been updated to safely handle termination, even if the thread was never started.