chore: conditionally process data address on resume flow#64
Closed
ronjaquensel wants to merge 1 commit intoeclipse-dataplane-core:mainfrom
Closed
chore: conditionally process data address on resume flow#64ronjaquensel wants to merge 1 commit intoeclipse-dataplane-core:mainfrom
ronjaquensel wants to merge 1 commit intoeclipse-dataplane-core:mainfrom
Conversation
ndr-brt
reviewed
Mar 27, 2026
Comment on lines
+206
to
+208
| var shouldReceiveDataAddress = (PROVIDER.equals(dataFlow.getType()) && dataFlow.isPush()) || | ||
| (CONSUMER.equals(dataFlow.getType()) && dataFlow.isPull()); | ||
| if (shouldReceiveDataAddress) { |
Contributor
There was a problem hiding this comment.
I'm not sure about this check, wouldn't the non null one already covering these cases? If the data plane receives a data address, it updates it, otherwise it uses the original one, unless there's a specific use case that we should avoid (eventually demonstrated by a test) I'd just leave the loose non-null check
Comment on lines
+217
to
+220
| var shouldProvideDataAddress = (PROVIDER.equals(dataFlow.getType()) && dataFlow.isPull()) || | ||
| (CONSUMER.equals(dataFlow.getType()) && dataFlow.isPush()); | ||
| var dataAddress = shouldProvideDataAddress ? dataFlow.getDataAddress() : null; | ||
| var response = new DataFlowStatusMessage(id, flowId, dataFlow.getState().name(), dataAddress, null); |
Contributor
There was a problem hiding this comment.
same, I think this is excessively defensive, unless there's a specific case for which the data address shouldn't be sent back, eventually let's try to describe it through a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds checks in the dataplane's
resumemethod toDataFlowResumeMessagewhen one should be expected (provider forpushtransfers, consumer forpulltransfers)DataFlowResumeMessagewhen one should be provided (provider forpulltransfers, consumer forpushtransfers)Depending on the control plane implementation, this may not be necessary, as e.g. a superfluous data address in the response may simply be ignored, but like this we can ensure that the dataplane handles data addresses in the
resumeflow as defined in the specification.