feat: adding web terminal ttyd editor definition#2107
feat: adding web terminal ttyd editor definition#2107ibuziuk merged 4 commits intoeclipse-che:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
|
@akurinnoy works like a charm with che-server on dogfooding \o/ @dkwon17 @tolusha @rgrunber please, review. Once merged in main I will apply this editor definition on Developer Sandbox stg / prod. Later on, we will need to decide if / when we would productize this initiative |
|
One caveat is that the tab's name is the command from https://github.com/eclipse-che/che-operator/pull/2107/changes#diff-c9e7ddd12500af43d0aaeed28636ad8c01c940eeb8919b9fb292103fffaf9b39R53 Would be better to just have it defined as "Terminal" .
|
rgrunber
left a comment
There was a problem hiding this comment.
LGTM. I tested a bunch of devfile images. I ran into the following error eventually though :
Failed to pull image "docker.io/tsl0922/ttyd:1.7.7-alpine": initializing source docker://tsl0922/ttyd:1.7.7-alpine: reading manifest 1.7.7-alpine in docker.io/tsl0922/ttyd: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit
Don't think I ever ran into this on quay, even when not authenticated. Are we ok with the image being on docker.io as opposed to quay.io ?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, rgrunber, tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I beileve we have to copy the image to quay.io |
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
@ibuziuk fixed - tab title is set to "Terminal" |
|
thank you all for review and follow up. |

What does this PR do?
Adding web terminal ttyd editor definition
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#23762
How to test this PR?
Editor definition applied on the dogfooding cluster:
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.