Skip to content

feat: adding web terminal ttyd editor definition#2107

Merged
ibuziuk merged 4 commits intoeclipse-che:mainfrom
ibuziuk:che-2376
Apr 1, 2026
Merged

feat: adding web terminal ttyd editor definition#2107
ibuziuk merged 4 commits intoeclipse-che:mainfrom
ibuziuk:che-2376

Conversation

@ibuziuk
Copy link
Copy Markdown
Member

@ibuziuk ibuziuk commented Mar 25, 2026

What does this PR do?

Adding web terminal ttyd editor definition

Screenshot/screencast of this PR

Screenshot 2026-03-25 at 16 35 34

What issues does this PR fix or reference?

eclipse-che/che#23762

How to test this PR?

Editor definition applied on the dogfooding cluster:

Screenshot 2026-03-30 at 16 25 45

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 25, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

ibuziuk added 2 commits March 27, 2026 14:13
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk
Copy link
Copy Markdown
Member Author

ibuziuk commented Mar 30, 2026

@akurinnoy works like a charm with che-server on dogfooding \o/

@dkwon17 @tolusha @rgrunber please, review. Once merged in main I will apply this editor definition on Developer Sandbox stg / prod. Later on, we will need to decide if / when we would productize this initiative

@ibuziuk
Copy link
Copy Markdown
Member Author

ibuziuk commented Mar 30, 2026

One caveat is that the tab's name is the command from https://github.com/eclipse-che/che-operator/pull/2107/changes#diff-c9e7ddd12500af43d0aaeed28636ad8c01c940eeb8919b9fb292103fffaf9b39R53

Would be better to just have it defined as "Terminal" .

Screenshot 2026-03-30 at 16 11 31

Copy link
Copy Markdown
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested a bunch of devfile images. I ran into the following error eventually though :

Failed to pull image "docker.io/tsl0922/ttyd:1.7.7-alpine": initializing source docker://tsl0922/ttyd:1.7.7-alpine: reading manifest 1.7.7-alpine in docker.io/tsl0922/ttyd: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit

Don't think I ever ran into this on quay, even when not authenticated. Are we ok with the image being on docker.io as opposed to quay.io ?

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, rgrunber, tolusha

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Copy Markdown
Contributor

tolusha commented Mar 31, 2026

I beileve we have to copy the image to quay.io

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 31, 2026

New changes are detected. LGTM label has been removed.

@akurinnoy
Copy link
Copy Markdown
Contributor

@ibuziuk fixed - tab title is set to "Terminal"

@ibuziuk ibuziuk merged commit 45b9a4e into eclipse-che:main Apr 1, 2026
18 checks passed
@ibuziuk
Copy link
Copy Markdown
Member Author

ibuziuk commented Apr 1, 2026

thank you all for review and follow up.
Merging in the current state, and we can address other concerns e.g. image registry later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants