Conversation
|
Click here to review and test in web IDE: |
Refactor workspace progress step components to use a dedicated onWarning callback instead of directly showing alerts for non-fatal warnings. This provides consistent warning handling across all progress steps and allows the parent component to manage warning display alongside errors. Changes include: - Add onWarning prop to ProgressStep base class and all step implementations - Replace direct appAlerts.showAlert() calls with handleWarning() in StartWorkspace step - Add warning display when devfile fetch fails and falls back to default devfile - Update all test files to include mockOnWarning callback Assisted-by: Claude Sonnet 4.5 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1507 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1507", name: che-dashboard}]}}]" |
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
==========================================
+ Coverage 92.24% 92.26% +0.02%
==========================================
Files 562 562
Lines 54906 55038 +132
Branches 4082 4106 +24
==========================================
+ Hits 50646 50783 +137
+ Misses 4213 4208 -5
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@vinokurig could you fix it? |
Add comprehensive test coverage for the onWarning callback in WorkspaceProgress component, including tests for active step warnings, non-active step handling, and duplicate warning prevention. Assisted-by: Claude Sonnet 4.5 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1507 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1507", name: che-dashboard}]}}]" |
...es/dashboard-frontend/src/components/WorkspaceProgress/CreatingSteps/Fetch/Devfile/index.tsx
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, vinokurig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Co-authored-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
New changes are detected. LGTM label has been removed. |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1507 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1507", name: che-dashboard}]}}]" |
4 participants
Assisted-by: Claude Sonnet 4.5
What does this PR do?
Refactor workspace progress step components to use a dedicated
onWarningcallback instead of directly showing alerts for non-fatal warnings. This provides consistent warning handling across all progress steps and allows the parent component to manage warning display alongside errors.Changes include:
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://redhat.atlassian.net/browse/CRW-10219
Is it tested? How?
Fetch Devfilestep, workspace starts from the default devfile:Release Notes
Docs PR