fix: track independent validation state for git config name and email…

[vinokurig]

… fields

What does this PR do?

Fixes form validation to properly track both name and email field validity independently, ensuring the form is only valid when both fields are valid.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://redhat.atlassian.net/browse/CRW-10296

Is it tested? How?

1. Open the User preferences page -> Gitconfig tab.
2. Enter some email (ex. "asd") - > see error -> enter some name -> Error is visible
3. See: the 'Save' button is NOT active.
4. Open the Import Git Configuration dialog and check the username and email properties in the same way.

Release Notes

Docs PR

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1506 (linux/amd64, linux/arm64)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1506", name: che-dashboard}]}}]"

[vinokurig]

/retest

[codecov]

Codecov Report

❌ Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.27%. Comparing base (6797295) to head (94a2acb).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...erences/GitConfig/AddModal/GitConfigForm/index.tsx	89.28%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
+ Coverage   92.24%   92.27%   +0.03%     
==========================================
  Files         562      562              
  Lines       54906    55039     +133     
  Branches     4082     4113      +31     
==========================================
+ Hits        50646    50786     +140     
+ Misses       4213     4206       -7     
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[olexii4]

LGTM

[olexii4]

@vinokurig We have another approach to changing the configuration using the "Import Git Configuration" button that should be fixed:

WDYT?

[akurinnoy]

please move these fields to component state.

In constructor:

this.state = {
  isNameValid: true,
  isEmailValid: true,
};

In handler:

this.setState({ isNameValid: isValid });

[vinokurig]

this.setState({ isNameValid: isValid }) will not update the state object instantly, so the
const isFormValid = this.state.isNameValid && this.state.isEmailValid will not work

[vinokurig]

@olexii4

We have another approach to changing the configuration using the "Import Git Configuration" button that should be fixed

done

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1506 (linux/amd64, linux/arm64)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1506", name: che-dashboard}]}}]"

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4, vinokurig

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olexii4]

/retest