Open
Conversation
added 2 commits
May 26, 2017 18:17
Owner
|
Thanks for your PR! Will review shortly. 😄 |
Owner
|
@hanpeic can you add a description that explains how this code works, and why it's needed? By the way, thanks for adding so many fixtures to the code! |
Author
|
Hi @ecin thanks for your quick reply. When I call this gem to parse QR code, I find some QR code parse failed, but if I upload to zxing.org, it could get the result. After I checked the source code of zxing.org, the key point is this line: It tries 'HybridBinarizer' to parse again if first time failed. so I add same code in this gem. to make sure if a QR code could parse by zxing.org, then It could parse by this gem too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated jar file version
improve QR code decode ability same as the website: zxing.org