feat: Google Compose Screenshot Testing support + confirm dialogs#31
Merged
feat: Google Compose Screenshot Testing support + confirm dialogs#31
Conversation
Screenshot Tests Failed0 test(s) failed: Download the diff images and HTML report from the workflow artifacts. |
When both delta_prefix and delta_suffix are empty, the scanner treats all PNGs in failures_dir as actuals and compares against goldens via byte comparison. Only files that differ are flagged as failures. Same profile structure as Paparazzi/Roborazzi — no special mode. - Built-in "Compose Screenshot" template: failures_dir points to rendered output, golden_patterns use ** for nested package dirs - Scanner recurses into subdirs when no delta convention is set - Size pre-check before byte comparison (skip read if sizes differ) - Detail view hides Delta tab when delta_path is null, defaults to Toggle - _cycleViewMode skips delta when unavailable - Review grid uses actual_path as thumbnail fallback - Module discovery finds build/outputs/screenshotTest-results/ - Profile editor respects empty delta_prefix - Confirm dialog on all destructive actions - Extract deriveModule helper, hoist Set constants to module scope - Fix TOCTOU: single statSync with try/catch - Use countPngsRecursive consistently for golden counts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
eboudrant
force-pushed
the
feat/compose-screenshot
branch
from
0f1751a to
3d7e2e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both delta_prefix and delta_suffix are empty, the scanner treats all PNGs in failures_dir as actuals and compares against goldens via byte comparison. Only files that differ are flagged as failures. Same profile structure as Paparazzi/Roborazzi — no special mode.