Skip to content

fakecgo: add s390x support for CGO_ENABLED=0#422

Open
gdams wants to merge 1 commit intoebitengine:mainfrom
gdams:s390x
Open

fakecgo: add s390x support for CGO_ENABLED=0#422
gdams wants to merge 1 commit intoebitengine:mainfrom
gdams:s390x

Conversation

@gdams
Copy link
Contributor

@gdams gdams commented Feb 25, 2026

What type of issue is this addressing?

feature

What this PR does | solves

Adds support for CGO_ENABLED=0 on s390x. Note that this will only work for Go 1.27+.

For those who want to test this you can easily do this via a docker container:

docker run --platform linux/s390x --rm \
  -v "$(pwd):/app" -w /app -e CGO_ENABLED=0 \
  golang:tip sh -lc '
    set -e
    mkdir -p /lib64
    ln -sf /usr/lib/s390x-linux-gnu/ld64.so.1 /lib64/ld64.so.1
    /usr/local/go/bin/go test .
  '

Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but we cannot have tests right now, right?

@gdams
Copy link
Contributor Author

gdams commented Feb 25, 2026

Interesting, but we cannot have tests right now, right?

that's correct, the upstream fix only exists in master so we can test using the above docker command but unfortunely setup-go doesn't support gotip and manually running this would significantly slow down CI. I'd suggest that given that's unsupported until 1.27 you can just enable the testing at that point?

@hajimehoshi
Copy link
Member

I suggest to hold this PR until Go 1.27 release candidate is released

@gdams
Copy link
Contributor Author

gdams commented Feb 25, 2026

I suggest to hold this PR until Go 1.27 release candidate is released

yup, I'm totally fine with this, I wanted to just get the assembly in a git repo somewhere so we didn't lose it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants