fakecgo: add s390x support for CGO_ENABLED=0#422
Open
gdams wants to merge 1 commit intoebitengine:mainfrom
Open
fakecgo: add s390x support for CGO_ENABLED=0#422gdams wants to merge 1 commit intoebitengine:mainfrom
gdams wants to merge 1 commit intoebitengine:mainfrom
Conversation
hajimehoshi
reviewed
Feb 25, 2026
Member
hajimehoshi
left a comment
There was a problem hiding this comment.
Interesting, but we cannot have tests right now, right?
Contributor
Author
that's correct, the upstream fix only exists in master so we can test using the above docker command but unfortunely setup-go doesn't support gotip and manually running this would significantly slow down CI. I'd suggest that given that's unsupported until 1.27 you can just enable the testing at that point? |
Member
|
I suggest to hold this PR until Go 1.27 release candidate is released |
Contributor
Author
yup, I'm totally fine with this, I wanted to just get the assembly in a git repo somewhere so we didn't lose it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of issue is this addressing?
feature
What this PR does | solves
Adds support for
CGO_ENABLED=0on s390x. Note that this will only work for Go 1.27+.For those who want to test this you can easily do this via a docker container: