Apply updated templates and fix Zenodo DOI#116
Conversation
AndrewSazonov
added
the
[scope] maintenance
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #116 +/- ##
==========================================
Coverage ? 97.68%
==========================================
Files ? 36
Lines ? 2328
Branches ? 388
==========================================
Hits ? 2274
Misses ? 33
Partials ? 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
henrikjacobsenfys
left a comment
henrikjacobsenfys
left a comment
There was a problem hiding this comment.
Looks good. Seems like the zenodo link doesn't work yet, but it does seem to point to the right place when I search on zenodo
🤔 Where? In the developer version of the documentation generated by this PR |
rozyczko
left a comment
rozyczko
left a comment
There was a problem hiding this comment.
copier-copy and related commands fail in standard installation
| copier-copy = "copier copy gh:easyscience/templates . --data-file ../dynamics/.copier-answers.yml --data template_type=lib" | ||
| copier-recopy = "copier recopy --data-file ../dynamics/.copier-answers.yml --data template_type=lib" | ||
| copier-update = "copier update --data-file ../dynamics/.copier-answers.yml --data template_type=lib" |
There was a problem hiding this comment.
Does this mean we also need to pull https://github.com/easyscience/dynamics?
How are we assuring this?
After installing dynamics-lib and running pixi run copier-copy I get
(sdk) C:\Users\piotr\projects\easy\dynamics-lib>pixi run copier-copy
✨ Pixi task (copier-copy in default): copier copy gh:easyscience/templates . --data-file ../dynamics/.copier-answers.yml --data template_type=lib Error: Argument of data-file expected to be ExistingFile, not '../dynamics/.copier-answers.yml':
ValueError('../dynamics/.copier-answers.yml is not a file')
There was a problem hiding this comment.
Yeah, we need to pull both dynamics and dynamics-lib. I described this process in the README in easyscience/templates.
Unfortunately, Copier cannot read the answers file from the web - it only supports local files 🙁. I tried to find a simple cross-platform workaround, but could not find a good solution.
I even wrote a script that downloads the answers file to a temporary location and then runs Copier using that file. But this introduced extra complexity and, in the end, was less maintainable than just having a few lines in the guide explaining the process.
Of course, I’m open to better alternatives if you have any suggestions.
|
The website gave an error, but should be good now |
3 participants
This PR applies the latest Copier templates and includes minor fixes in scripts and formatting. It also corrects the Zenodo DOI in the documentation.