Bugfix/ignore outside densities

[JenHardt]

Making of ignoreOutsideDensities and useGivenEqDensityCube consistent between stf generation and dose engines, a problem for the dose engines arose because the analytcial calculation was performed on the RSP cube, where ignoreOutsideDensities was applied, but the MC would often dirrectly use the HU cube to do material conversion, where this was not applied

[read-the-docs-community]

Documentation build overview

📚 matRad | 🛠️ Build #32182751 | 📁 Comparing 144b1eb against latest (c014dc8)

  🔍 Preview build  

Show files changed (12 files in total): 📝 12 modified | ➕ 0 added | ➖ 0 deleted

File	Status
genindex.html	📝 modified
index.html	📝 modified
api/doseCalc.html	📝 modified
api/steering.html	📝 modified
datastructures/pln.html	📝 modified
datastructures/stf.html	📝 modified
overview/about.html	📝 modified
overview/cite.html	📝 modified
overview/faq.html	📝 modified
quickstart/index.html	📝 modified
setup/download.html	📝 modified
setup/requirements.html	📝 modified

[codecov]

Codecov Report

❌ Patch coverage is 64.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.83%. Comparing base (b0b07e2) to head (144b1eb).

Files with missing lines	Patch %	Lines
...nes/@matRad_DoseEngineBase/matRad_DoseEngineBase.m	69.56%	7 Missing ⚠️
matRad/MatRad_Config.m	0.00%	4 Missing ⚠️
matRad/util/matRad_interp3.m	42.85%	4 Missing ⚠️
matRad/steering/matRad_StfGeneratorBase.m	81.25%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #900      +/-   ##
==========================================
- Coverage   54.84%   54.83%   -0.01%     
==========================================
  Files         320      320              
  Lines       20525    20544      +19     
==========================================
+ Hits        11256    11265       +9     
- Misses       9269     9279      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Test Results

    3 files  ±0      3 suites  ±0   32m 23s ⏱️ - 1m 6s
  358 tests +1    358 ✅ +1  0 💤 ±0  0 ❌ ±0 
1 170 runs  +3  1 165 ✅ +3  5 💤 ±0  0 ❌ ±0 

Results for commit 144b1eb. ± Comparison against base commit b0b07e2.

♻️ This comment has been updated with latest results.

[wahln]

This is very nice for computation consistency, thanks.

The code itself looks very nice, but could you add some minimal tests to check the correct behavior? Probably its difficult to catch the corresponding warnings, but you could probably check the resulting dose / generated stf's if you see the expected discrepancies.

[wahln]

Additionally, some documentation for this consistency between stf and dosecalc might be helpful

[JenHardt]

This is very nice for computation consistency, thanks.

The code itself looks very nice, but could you add some minimal tests to check the correct behavior? Probably its difficult to catch the corresponding warnings, but you could probably check the resulting dose / generated stf's if you see the expected discrepancies.

i think to check the expected result i would have to create a new test ct, because our current dummy test ct only has air outside of the patient anyway. I could create a new one with a dummy couch to test the behavior