Class based Sequencing by JenHardt · Pull Request #891 · e0404/matRad

JenHardt · 2026-02-27T13:31:14Z

Implementation of a class to handle the photon sequencing with the three algorithims siochi, xia, engle as well as an ion sequencer

incorperation of the three photon sequencing algorithims and update of the base class

codecov · 2026-02-27T13:44:08Z

Codecov Report

❌ Patch coverage is 59.22250% with 493 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.77%. Comparing base (bf8adb3) to head (5b6e8a8).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines	Patch %	Lines
matRad/gui/widgets/matRad_WorkflowWidget.m	16.43%	183 Missing ⚠️
...ring/matRad_StfGeneratorExternalRayBixelAbstract.m	38.93%	69 Missing ⚠️
matRad/sequencing/matRad_PhotonSequencerAbstract.m	70.40%	66 Missing ⚠️
matRad/sequencing/matRad_SequencerBase.m	58.33%	55 Missing ⚠️
...atRad/sequencing/matRad_SequencingPhotonsXiaLeaf.m	73.68%	20 Missing ⚠️
...ad/sequencing/matRad_SequencingPhotonsSiochiLeaf.m	88.42%	14 Missing ⚠️
...Rad/sequencing/matRad_SequencingPhotonsEngelLeaf.m	88.88%	12 Missing ⚠️
matRad/4D/matRad_acc4dDose.m	47.61%	11 Missing ⚠️
matRad/4D/matRad_calc4dDose.m	60.00%	10 Missing ⚠️
matRad/sequencing/matRad_engelLeafSequencing.m	0.00%	10 Missing ⚠️
... and 9 more

Additional details and impacted files

@@            Coverage Diff             @@
##             dev     #891       +/-   ##
==========================================
+ Coverage   0.00%   54.77%   +54.77%     
==========================================
  Files        310      317        +7     
  Lines      20289    20458      +169     
==========================================
+ Hits           0    11205    +11205     
+ Misses     20289     9253    -11036

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2026-02-27T14:00:51Z

Test Results

3 files 3 suites 43m 33s ⏱️
354 tests 354 ✅ 0 💤 0 ❌
1 158 runs 1 153 ✅ 5 💤 0 ❌

Results for commit 5b6e8a8.

♻️ This comment has been updated with latest results.

wahln · 2026-02-27T14:06:11Z

There seem to be a bunch of unhappy tests in this PR ;-)

wahln · 2026-02-27T14:10:01Z

Also I am confused about the changed 4D capabilities (that don't seem to have anything to do with sequencing in parts).
Also, we should keep downwards compatibility with the old sequencing calls for a while.

wahln

Did some preliminary rough review.

wahln · 2026-03-04T15:54:04Z

matRad/matRad_sequencing.m

@@ -1,4 +1,4 @@
-function resultGUI = matRad_sequencing(resultGUI,stf,dij,pln,visBool)
+function resultGUI = matRad_sequencing(resultGUI,stf,pln,dij,visMode)


Is there a reason why the dij has become optional? This is a huge change without much benefit it seems.

it is just because the dij is just used to recalculate the dose based on the new sequenced weight vector, but you could run the sequencing independently

wahln · 2026-03-04T15:56:15Z

matRad/4D/matRad_acc4dDose.m

This could probably still be removed?

wahln · 2026-03-04T15:56:43Z

matRad/4D/matRad_calc4dDose.m

@@ -1,29 +1,23 @@
-function [resultGUI, timeSequence] = matRad_calc4dDose(ct, pln, dij, stf, cst, resultGUI, totalPhaseMatrix,accType)
+function resultGUI = matRad_calc4dDose(dij, pln,stf,resultGUI, totalPhaseMatrix)


why did the argument list chagne so drastically?

the ct was only used to save the number of ct scenarios and the motion period , this should now be in the pln scenario model and the cst was used for the ax and bx vectors this is taken directly from the dij

okay let's approach it from the other way: can we avoid the pln struct when using the ct?
I would like to keep pln out of lower-level functions as much as possible, and only pass it to top-level workflow functions (as the pln can, for example, be easily changed in the GUI and lead to inconsistent inputs).

i think this can be done, but then i need the ct again,

no acctually i need it to selecect the sequencer and calculate the phaseMatrix if not given, although right now the phaseMatrix is only calculated for ions not photons

wahln · 2026-03-04T15:57:25Z

matRad/4D/matRad_makeBixelTimeSeq.m

Isn#t this a function that should actually be moved into the IonSequencer?

it is this was one of the files i deleted, where i just now reverted the delition to make it backwards compatible, i haved pushed the update to this file jet

matRad/sequencing/matRad_SequencerBase.m

matRad/sequencing/matRad_ParticleSequencer.m

matRad/sequencing/matRad_PhotonSequencerAbstract.m

wahln · 2026-03-04T16:00:53Z

matRad/matRad_directApertureOptimization.m

Change in the interface destroys downwards compatibility.. Is this necessary?

i removed it because it was never used in the function

wahln · 2026-03-04T16:02:06Z

matRad/matRad_sequencingOld.m

Naming the file sequencingOld and the function still sequencing will create problems. I suggest to not change the interface of the sequencing call (with the optional dij at the end) but just keep the old interface (resultGUI,stf,dij,pln,visBool) -> visBool can become visMode, this is still OK just selecting the visMode 1 if it is true.

similar to above this is an issue of the delition and reverting of the delition that is not completet yet

wahln · 2026-03-04T16:02:35Z

submodules/ompMC

What is changed in the submodule? Is this intentional?

…ate of test data

JenHardt added 15 commits June 27, 2025 17:27

first very rough draft of sequecing class with SiochiLeaf Implementation

e867f80

Merge branch 'dev' into dev_Sequencing

c4a105a

Merge branch 'dev' into dev_Sequencing

87ddbe3

updates to sequencing

3c43496

incorperation of the three photon sequencing algorithims and update of the base class

continuationof sequencing

dcb8749

Merge branch 'dev' into dev_Sequencing

9331425

Update ompMC

bb931d3

delete old files

4bbfe0f

updated 3d conformal

b777135

part of class now

68ea49a

part of ion sequencer class

cb40953

removed unused opt result

f4e74e4

updated DAO example

460f8ba

remove unnecessary update ResultGUi

5bdd747

set fill empty Bixels to true to fix DAO issue with empty bixels

dd36310

JenHardt added 3 commits March 4, 2026 13:36

restore Files

6e7ca5b

revert files

a307a62

revert files

dc96b20

wahln mentioned this pull request Mar 4, 2026

Update on merging VMAT into dev #377

Open

wahln requested changes Mar 4, 2026

View reviewed changes

JenHardt added 6 commits March 6, 2026 15:13

updates test

f28cf64

fill empty bixels only for photons so not to interfer so much and upd…

2a138b5

…ate of test data

changing of names

f1fca5a

updates of old functions

d511408

merge dev branch

cbbed97

merge dev

aaea936

octave6fix

5b6e8a8

		@@ -1,4 +1,4 @@
		function resultGUI = matRad_sequencing(resultGUI,stf,dij,pln,visBool)
		function resultGUI = matRad_sequencing(resultGUI,stf,pln,dij,visMode)

		@@ -1,29 +1,23 @@
		function [resultGUI, timeSequence] = matRad_calc4dDose(ct, pln, dij, stf, cst, resultGUI, totalPhaseMatrix,accType)
		function resultGUI = matRad_calc4dDose(dij, pln,stf,resultGUI, totalPhaseMatrix)

Conversation

JenHardt commented Feb 27, 2026

Uh oh!

codecov bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

wahln commented Feb 27, 2026

Uh oh!

wahln commented Feb 27, 2026

Uh oh!

wahln left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Feb 27, 2026 •

edited

Loading

github-actions bot commented Feb 27, 2026 •

edited

Loading